geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3299) Gfsh functions should acquire Cache from FunctionContext
Date Tue, 24 Oct 2017 22:35:00 GMT


ASF GitHub Bot commented on GEODE-3299:

pdxrunner opened a new pull request #975: GEODE-3299: throw CacheClosedException in FunctionContext.getCache()
   Throw the exception when cache == null instead of returning the null.
   Gfsh functions handle CacheClosedException, whereas
   NullPointerExceptions that resulted from returning null are not.
   Thank you for submitting a contribution to Apache Geode.
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   - [X] Has your PR been rebased against the latest commit within the target branch (typically
   - [X] Is your initial contribution a single, squashed commit?
   - [X] Does `gradlew build` run cleanly?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Gfsh functions should acquire Cache from FunctionContext
> --------------------------------------------------------
>                 Key: GEODE-3299
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Kirk Lund
>            Assignee: Kenneth Howe
>             Fix For: 1.4.0
> Gfsh functions in geode-core currently
acquire a reference to the Cache in several ways including from a singleton in CacheFactory
which is prone to deadlocking. They should be modified to uniformly acquire the Cache from
FunctionContext instead.

This message was sent by Atlassian JIRA

View raw message