geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruce Schuchardt (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (GEODE-3059) LoadMonitor.connectionClosed incrementing statistics only for client-server connection
Date Fri, 01 Sep 2017 19:14:00 GMT

     [ https://issues.apache.org/jira/browse/GEODE-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bruce Schuchardt resolved GEODE-3059.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.3.0

> LoadMonitor.connectionClosed incrementing statistics only for client-server connection
> --------------------------------------------------------------------------------------
>
>                 Key: GEODE-3059
>                 URL: https://issues.apache.org/jira/browse/GEODE-3059
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Galen O'Sullivan
>             Fix For: 1.3.0
>
>
> The logic in {{LoadMonitor.connectionClosed}} looks wrong, or at least is quite counterintuitive.
The connection count is decremented only if this is a client-server connection, which looks
wrong, and the client count should be only if it's a client-to-server connection.
> We need to look at Gateway connections as well, and for the new client-server protocol.
> {code}
>   public void connectionClosed(boolean lastConnection, byte communicationMode) {
>     if (communicationMode == Acceptor.CLIENT_TO_SERVER) {
>       metrics.decConnectionCount();
>     }
>     if (lastConnection) {
>       metrics.decClientCount();
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message