geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3059) LoadMonitor.connectionClosed incrementing statistics only for client-server connection
Date Fri, 01 Sep 2017 19:13:02 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151036#comment-16151036
] 

ASF subversion and git services commented on GEODE-3059:
--------------------------------------------------------

Commit fecec42fb57630a669b653ccb54a97b42948d219 in geode's branch refs/heads/develop from
[~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fecec42 ]

GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

The stat should only be incremented/decremented for certain kinds of
connections.  I've modified it to include protobuf connections.  All
of the constant byte identifiers in Acceptor.java have been moved to
an enum in CommunicationMode.java.  In that class I've added some
"isa" checks to replace the many big "if" checks for different kinds
of connection modes.

A new connection modes will henceforth need to be added to
CommunicationMode.java where the appropriate "isa" methods can be
updated to include the new mode.


> LoadMonitor.connectionClosed incrementing statistics only for client-server connection
> --------------------------------------------------------------------------------------
>
>                 Key: GEODE-3059
>                 URL: https://issues.apache.org/jira/browse/GEODE-3059
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Galen O'Sullivan
>
> The logic in {{LoadMonitor.connectionClosed}} looks wrong, or at least is quite counterintuitive.
The connection count is decremented only if this is a client-server connection, which looks
wrong, and the client count should be only if it's a client-to-server connection.
> We need to look at Gateway connections as well, and for the new client-server protocol.
> {code}
>   public void connectionClosed(boolean lastConnection, byte communicationMode) {
>     if (communicationMode == Acceptor.CLIENT_TO_SERVER) {
>       metrics.decConnectionCount();
>     }
>     if (lastConnection) {
>       metrics.decClientCount();
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message