Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Fri, 25 Aug 2017 21:56:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13097693.1503691276000.124759.1503698160875@Atlassian.JIRA>
In-Reply-To: <JIRA.13097693.1503691276000@Atlassian.JIRA>
References: <JIRA.13097693.1503691276000@Atlassian.JIRA> <JIRA.13097693.1503691276515@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3522) puts via a load need to update AEQ
 and data region under a single lock (to prevent bucket movement during
 processing)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 25 Aug 2017 21:56:07 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3522?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1614=
2291#comment-16142291 ]=20

ASF GitHub Bot commented on GEODE-3522:
---------------------------------------

GitHub user ladyVader opened a pull request:

    https://github.com/apache/geode/pull/744

    GEODE-3522: create via load needs to add event to AEQ under same lock=
=E2=80=A6

    =E2=80=A6 as update to local region
   =20
    * create via load was invoking handleWANEvent prior to obtaining a lock=
, which allowed rebalance to
      shift the primary between AEQ update and data region update.
    * moved call to handleWANEvent from DistributedRegion to BucketRegion t=
o synchronize these two actions.
   =20
    @upthewaterspout, @boglesby
   =20
    Thank you for submitting a contribution to Apache Geode.
   =20
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
   =20
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced =
in the commit message?
   =20
    - [ ] Has your PR been rebased against the latest commit within the tar=
get branch (typically `develop`)?
   =20
    - [ ] Is your initial contribution a single, squashed commit?
   =20
    - [ ] Does `gradlew build` run cleanly?
   =20
    - [ ] Have you written or updated unit tests to verify your changes?
   =20
    - [ ] If adding new dependencies to the code, are these dependencies li=
censed in a way that is compatible for inclusion under [ASF 2.0](http://www=
.apache.org/legal/resolved.html#category-a)?
   =20
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for bu=
ild issues and
    submit an update to your PR as soon as possible. If you need help, plea=
se send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/geode feature/GEODE-3522

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #744
   =20
----
commit afbfd708185cc7ed82490699c033c40263e4aa76
Author: Lynn Hughes-Godfrey <lhughesgodfrey@pivotal.io>
Date:   2017-08-25T21:46:17Z

    GEODE-3522: create via load needs to add event to AEQ under same lock a=
s update to local region
   =20
    * create via load was invoking handleWANEvent prior to obtaining a lock=
, which allowed rebalance to
      shift the primary between AEQ update and data region update.
    * moved call to handleWANEvent from DistributedRegion to BucketRegion t=
o synchronize these two actions.

----


> puts via a load need to update AEQ and data region under a single lock (t=
o prevent bucket movement during processing)
> -------------------------------------------------------------------------=
--------------------------------------------
>
>                 Key: GEODE-3522
>                 URL: https://issues.apache.org/jira/browse/GEODE-3522
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>    Affects Versions: 1.2.0, 1.3.0, 1.2.1
>            Reporter: Shelley Lynn Hughes-Godfrey
>            Assignee: Shelley Lynn Hughes-Godfrey
>
> New entries created via a loader can miss creating their lucene index if =
the primary is moved between adding the entry to the AEQ and into the local=
Region.
> handleWANEvent needs to be executed under the same lock held for putting =
a new entry into the data region.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)