Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Thu, 24 Aug 2017 23:31:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13094884.1502836779000.116878.1503617460719@Atlassian.JIRA>
In-Reply-To: <JIRA.13094884.1502836779000@Atlassian.JIRA>
References: <JIRA.13094884.1502836779000@Atlassian.JIRA> <JIRA.13094884.1502836779632@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3447) Implement client authorization for
 the new protocol
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 24 Aug 2017 23:31:08 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3447?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1614=
0933#comment-16140933 ]=20

ASF GitHub Bot commented on GEODE-3447:
---------------------------------------

Github user pivotal-amurmann commented on a diff in the pull request:

    https://github.com/apache/geode/pull/719#discussion_r135154701
 =20
    --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/Author=
izationIntegrationTest.java ---
    @@ -0,0 +1,206 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more =
contributor license
    + * agreements. See the NOTICE file distributed with this work for addi=
tional information regarding
    + * copyright ownership. The ASF licenses this file to You under the Ap=
ache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the=
 License. You may obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software=
 distributed under the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITION=
S OF ANY KIND, either express
    + * or implied. See the License for the specific language governing per=
missions and limitations under
    + * the License.
    + */
    +package org.apache.geode.protocol;
    +
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertTrue;
    +import static org.mockito.ArgumentMatchers.any;
    +import static org.mockito.ArgumentMatchers.same;
    +import static org.mockito.Mockito.mock;
    +import static org.mockito.Mockito.when;
    +
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.OutputStream;
    +import java.net.Socket;
    +import java.util.Properties;
    +import java.util.concurrent.TimeUnit;
    +
    +import org.awaitility.Awaitility;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.junit.contrib.java.lang.system.RestoreSystemProperties;
    +import org.junit.experimental.categories.Category;
    +
    +import org.apache.geode.cache.Cache;
    +import org.apache.geode.cache.CacheFactory;
    +import org.apache.geode.cache.server.CacheServer;
    +import org.apache.geode.internal.AvailablePortHelper;
    +import org.apache.geode.management.internal.security.ResourceConstants=
;
    +import org.apache.geode.protocol.protobuf.AuthenticationAPI;
    +import org.apache.geode.protocol.protobuf.ClientProtocol;
    +import org.apache.geode.protocol.protobuf.ProtobufSerializationService=
;
    +import org.apache.geode.protocol.protobuf.ProtocolErrorCode;
    +import org.apache.geode.protocol.protobuf.RegionAPI;
    +import org.apache.geode.protocol.protobuf.serializer.ProtobufProtocolS=
erializer;
    +import org.apache.geode.protocol.protobuf.utilities.ProtobufUtilities;
    +import org.apache.geode.security.ResourcePermission;
    +import org.apache.geode.security.SecurityManager;
    +import org.apache.geode.serialization.registry.exception.CodecAlreadyR=
egisteredForTypeException;
    +import org.apache.geode.test.junit.categories.IntegrationTest;
    +
    +@Category(IntegrationTest.class)
    +public class AuthorizationIntegrationTest {
    --- End diff --
   =20
    Hugs for not adding this to the existing Roundtrip test! =F0=9F=A4=97


> Implement client authorization for the new protocol
> ---------------------------------------------------
>
>                 Key: GEODE-3447
>                 URL: https://issues.apache.org/jira/browse/GEODE-3447
>             Project: Geode
>          Issue Type: New Feature
>          Components: client/server
>            Reporter: Brian Baynes
>            Assignee: Bruce Schuchardt
>
> As a user of the new client/server protocol, I need to make sure the clie=
nts using the protocol to access my grid are authorized to perform each ope=
ration they attempt.
> Implement client authorization for operations in new protocol based on ex=
isting authorization configuration.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)