Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4190B200CDF for ; Thu, 17 Aug 2017 23:38:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3FD5A16BDE6; Thu, 17 Aug 2017 21:38:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8AB9416BDE5 for ; Thu, 17 Aug 2017 23:38:03 +0200 (CEST) Received: (qmail 48272 invoked by uid 500); 17 Aug 2017 21:38:02 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 48263 invoked by uid 99); 17 Aug 2017 21:38:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2017 21:38:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2051CC008F for ; Thu, 17 Aug 2017 21:38:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id V1TAso8pEL8C for ; Thu, 17 Aug 2017 21:38:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 264955F1B3 for ; Thu, 17 Aug 2017 21:38:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 991C4E041C for ; Thu, 17 Aug 2017 21:38:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4B32B2537B for ; Thu, 17 Aug 2017 21:38:00 +0000 (UTC) Date: Thu, 17 Aug 2017 21:38:00 +0000 (UTC) From: "Eric Shu (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (GEODE-3438) Collection added to itself MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 17 Aug 2017 21:38:04 -0000 [ https://issues.apache.org/jira/browse/GEODE-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Shu updated GEODE-3438: ---------------------------- Component/s: (was: core) querying > Collection added to itself > -------------------------- > > Key: GEODE-3438 > URL: https://issues.apache.org/jira/browse/GEODE-3438 > Project: Geode > Issue Type: Bug > Components: querying > Reporter: JC > > Hi > In a recent github mirror, I've found suspicious code. > Branch: master > Path: geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DurableCqNamesResult.java > {code:java} > ... > 27 private List cqNames = new ArrayList(); > ... > 33 public DurableCqNamesResult(final String memberNameOrId, List cqNames) { > 34 super(memberNameOrId); > 35 cqNames.addAll(cqNames); > 36 } > {code} > In Line 35, should `cqNames.addAll' be `this.cqNames.addAll'? This might not be an issue, but I wanted to report just in case. > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)