Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Tue, 15 Aug 2017 16:08:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13093583.1502307719000.34602.1502813280349@Atlassian.JIRA>
In-Reply-To: <JIRA.13093583.1502307719000@Atlassian.JIRA>
References: <JIRA.13093583.1502307719000@Atlassian.JIRA> <JIRA.13093583.1502307719187@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3416) Reduce blocking for
 SocketCloser.asyncClose
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 15 Aug 2017 16:08:05 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127442#comment-16127442 ] 

ASF GitHub Bot commented on GEODE-3416:
---------------------------------------

Github user WireBaron commented on a diff in the pull request:

    https://github.com/apache/geode/pull/702#discussion_r133230687
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
    @@ -144,35 +156,22 @@ private boolean isClosed() {
        * called then the asyncClose will be done synchronously.
        */
       public void close() {
    -    synchronized (asyncCloseExecutors) {
    +    synchronized (closed) {
           if (!this.closed) {
             this.closed = true;
    -        for (ThreadPoolExecutor pool : asyncCloseExecutors.values()) {
    -          pool.shutdown();
    -        }
    -        asyncCloseExecutors.clear();
    +      } else {
    +        return;
           }
         }
    +    for (ExecutorService executorService : asyncCloseExecutors.values()) {
    +      executorService.shutdown();
    +      asyncCloseExecutors.clear();
    --- End diff --
    
    Shouldn't this be outside the for loop?


> Reduce blocking for SocketCloser.asyncClose 
> --------------------------------------------
>
>                 Key: GEODE-3416
>                 URL: https://issues.apache.org/jira/browse/GEODE-3416
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>    Affects Versions: 1.1.0, 1.1.1, 1.2.0, 1.2.1
>            Reporter: Udo Kohlmeyer
>            Assignee: Udo Kohlmeyer
>             Fix For: 1.3.0
>
>
> In the SocketCloser.asyncClose method, there is a synchronization block around at HashMap. This synchronization will cause an effective single-threaded processing capability when closing sockets. this effect becomes more evident with a high number of clients.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)