Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Wed, 9 Aug 2017 20:43:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13093546.1502299643000.132434.1502311380347@Atlassian.JIRA>
In-Reply-To: <JIRA.13093546.1502299643000@Atlassian.JIRA>
References: <JIRA.13093546.1502299643000@Atlassian.JIRA> <JIRA.13093546.1502299643144@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3413) Overhaul launcher tests and process
 tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 09 Aug 2017 20:43:10 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120631#comment-16120631 ] 

ASF GitHub Bot commented on GEODE-3413:
---------------------------------------

Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132301005
  
    --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java ---
    @@ -0,0 +1,74 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
    + * or implied. See the License for the specific language governing permissions and limitations under
    + * the License.
    + */
    +
    +package org.apache.geode.internal.process.lang;
    --- End diff --
    
    Ideally there would be a test for 'findAvailablePid(existing processPid)' returns a random pid. 


> Overhaul launcher tests and process tests
> -----------------------------------------
>
>                 Key: GEODE-3413
>                 URL: https://issues.apache.org/jira/browse/GEODE-3413
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>              Labels: LauncherTest, ProcessTest
>
> The launcher and process tests are closely related and in need of overhauling to improve debugging and remove flakiness.
> In addition, the org.apache.geode.internal.process package is need of improving the test code coverage.
> Launcher tests:
> * geode-assembly/src/test/java/org/apache/geode/distributed/LocatorLauncherAssemblyIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherServiceStatusTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LauncherMemberMXBeanIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherLocalFileIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherLocalIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteFileIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteWithCustomLoggingIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorStateTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherLocalFileIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherLocalIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteFileIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteWithCustomLoggingIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteWithCustomLoggingIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherWithProviderIntegrationTest.java
> Process tests:
> * geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/LocalProcessControllerJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/LocalProcessLauncherDUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/LocalProcessLauncherJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/NonBlockingProcessStreamReaderJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/PidFileJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/ProcessControllerFactoryJUnitTest.java


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)