Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 22D93200CFA for ; Wed, 16 Aug 2017 01:19:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 21C71167B24; Tue, 15 Aug 2017 23:19:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 72952167B27 for ; Wed, 16 Aug 2017 01:19:05 +0200 (CEST) Received: (qmail 50929 invoked by uid 500); 15 Aug 2017 23:19:04 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 50920 invoked by uid 99); 15 Aug 2017 23:19:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2017 23:19:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id ADF87C099F for ; Tue, 15 Aug 2017 23:19:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ocIQCuRmJXyw for ; Tue, 15 Aug 2017 23:19:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EFD8D5FB0B for ; Tue, 15 Aug 2017 23:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6CB72E0E1C for ; Tue, 15 Aug 2017 23:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AD6A6218F3 for ; Tue, 15 Aug 2017 23:19:00 +0000 (UTC) Date: Tue, 15 Aug 2017 23:19:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-3249) Validate internal client/server messages MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 15 Aug 2017 23:19:06 -0000 [ https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128046#comment-16128046 ] ASF subversion and git services commented on GEODE-3249: -------------------------------------------------------- Commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232 in geode's branch refs/heads/feature/GEODE-3249b from [~bschuchardt] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f8e7ddd ] GEODE-3249: Validate internal client/server messages This was merely a matter of changing the server to require the credentials and changing the client to send credentials. I removed the general overriding of AbstractOp.processSecureBytes() because it made no sense. If the server sends a secure byte "part" in a message the client is obligated to process it or the next message it sends will cause a security violation. I've added a server-side property that folks can set to allow old clients to continue to work. This must be used to roll the servers forward to the new version that contains this change. Clients must then be rolled forward & the servers can then be rolled once again without the property set. The system property is geode.allow-internal-messages-without-credentials=true > Validate internal client/server messages > ---------------------------------------- > > Key: GEODE-3249 > URL: https://issues.apache.org/jira/browse/GEODE-3249 > Project: Geode > Issue Type: Bug > Components: messaging > Reporter: Anthony Baker > Assignee: Bruce Schuchardt > Fix For: 1.2.1 > > > Some message types can not be invoked directly by an end user. For validation purposes, we should treat these messages the same way we treat normal messages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)