Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B7CE9200497 for ; Wed, 23 Aug 2017 18:17:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B613C169069; Wed, 23 Aug 2017 16:17:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 09531169064 for ; Wed, 23 Aug 2017 18:17:06 +0200 (CEST) Received: (qmail 87471 invoked by uid 500); 23 Aug 2017 16:17:04 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 87456 invoked by uid 99); 23 Aug 2017 16:17:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2017 16:17:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9C0751A0627 for ; Wed, 23 Aug 2017 16:17:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id l8VeIaQpbJ1a for ; Wed, 23 Aug 2017 16:17:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 303D35F4DC for ; Wed, 23 Aug 2017 16:17:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 40F36E0AF9 for ; Wed, 23 Aug 2017 16:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9ACDC2480E for ; Wed, 23 Aug 2017 16:17:00 +0000 (UTC) Date: Wed, 23 Aug 2017 16:17:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-3249) Validate internal client/server messages MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 23 Aug 2017 16:17:07 -0000 [ https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138554#comment-16138554 ] ASF subversion and git services commented on GEODE-3249: -------------------------------------------------------- Commit c8a365418fd185198b61113991e2947dc69d249e in geode's branch refs/heads/release/1.2.1 from [~bschuchardt] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c8a3654 ] GEODE-3249: Validate internal client/server messages This is a squashed commit of the following from feature/GEODE-3249b: commit c16b151e57169733186f0c029d1957da32d59635 "spotless" fixes commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232 GEODE-3249: Validate internal client/server messages This was merely a matter of changing the server to require the credentials and changing the client to send credentials. I removed the general overriding of AbstractOp.processSecureBytes() because it made no sense. If the server sends a secure byte "part" in a message the client is obligated to process it or the next message it sends will cause a security violation. I've added a server-side property that folks can set to allow old clients to continue to work. This must be used to roll the servers forward to the new version that contains this change. Clients must then be rolled forward & the servers can then be rolled once again without the property set. The system property is geode.allow-internal-messages-without-credentials=true (cherry picked from commit 6be38cad729d56f355c7586ec994bfef933c5e65) > Validate internal client/server messages > ---------------------------------------- > > Key: GEODE-3249 > URL: https://issues.apache.org/jira/browse/GEODE-3249 > Project: Geode > Issue Type: Bug > Components: docs, messaging > Reporter: Anthony Baker > Assignee: Karen Smoler Miller > Fix For: 1.3.0, 1.2.1 > > > Some message types can not be invoked directly by an end user. For validation purposes, we should treat these messages the same way we treat normal messages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)