Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 196D7200497 for ; Wed, 23 Aug 2017 20:34:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 17C9B16955F; Wed, 23 Aug 2017 18:34:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 60480169563 for ; Wed, 23 Aug 2017 20:34:06 +0200 (CEST) Received: (qmail 37140 invoked by uid 500); 23 Aug 2017 18:34:05 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 37131 invoked by uid 99); 23 Aug 2017 18:34:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2017 18:34:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0C44CC0169 for ; Wed, 23 Aug 2017 18:34:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id OQzv-3rNNoy0 for ; Wed, 23 Aug 2017 18:34:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BEA7E5F570 for ; Wed, 23 Aug 2017 18:34:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 276FBE099C for ; Wed, 23 Aug 2017 18:34:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7375625386 for ; Wed, 23 Aug 2017 18:34:01 +0000 (UTC) Date: Wed, 23 Aug 2017 18:34:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-3184) Clean up session replication testing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 23 Aug 2017 18:34:07 -0000 [ https://issues.apache.org/jira/browse/GEODE-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138851#comment-16138851 ] ASF GitHub Bot commented on GEODE-3184: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/722 > Clean up session replication testing > ------------------------------------ > > Key: GEODE-3184 > URL: https://issues.apache.org/jira/browse/GEODE-3184 > Project: Geode > Issue Type: Improvement > Components: http session > Reporter: David Anuta > Assignee: David Anuta > Priority: Minor > > Would be good to review the code base and make sure methods are properly organized. > Also, the previous session replication testing is still in place in the extensions folder. This needs to be reviewed and any tests not covered by cargo should be transferred over into the new cargo replication testing. An example of something within this that needs to be cleaned up would be QueryCommand and CommandServlet classes, which are both in the extensions/geode-modules and extensions/session-testing-war projects. the QueryCommand and Command Servlet class within the extensions/geode-modules project could be removed if the previous session tests were all ported to cargo and then removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)