geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3508) Removed unused internal deprecated classes.
Date Wed, 23 Aug 2017 21:59:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139212#comment-16139212
] 

ASF GitHub Bot commented on GEODE-3508:
---------------------------------------

Github user PurelyApplied commented on a diff in the pull request:

    https://github.com/apache/geode/pull/734#discussion_r134881817
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
---
    @@ -1,33 +0,0 @@
    -/*
    - * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    - * agreements. See the NOTICE file distributed with this work for additional information
regarding
    - * copyright ownership. The ASF licenses this file to You under the Apache License, Version
2.0 (the
    - * "License"); you may not use this file except in compliance with the License. You may
obtain a
    - * copy of the License at
    - *
    - * http://www.apache.org/licenses/LICENSE-2.0
    - *
    - * Unless required by applicable law or agreed to in writing, software distributed under
the License
    - * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express
    - * or implied. See the License for the specific language governing permissions and limitations
under
    - * the License.
    - */
    -package org.apache.geode.internal.process;
    -
    -/**
    - * Exception thrown during server startup when it requests the locators for shared configuration
and
    - * does not receive it.
    - *
    - * @since GemFire 8.0
    - * @deprecated Please use
    --- End diff --
    
    Looks like `@deprecated` wants to be one, too.  Better use those backticks.
    
    I definitely misread those annotations, yes.  I should get in the habit of checking the
`git blame` to be sure about the deprecation date.
    
    Other than the reason you mentioned -- possibly using it during a rolling upgrade -- is
there a good reason to deprecate an internal class instead of simply removing it?  It was
my understanding that internal packages didn't hold any promise of API stability.  Or could
there be a backwards-compatibility issue that I'm not seeing?


> Removed unused internal deprecated classes.
> -------------------------------------------
>
>                 Key: GEODE-3508
>                 URL: https://issues.apache.org/jira/browse/GEODE-3508
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>
> The following classes are internal, deprecated, and (essentially) unused.
> {noformat}
> geode-core/src/main/java/org/apache/geode/distributed/internal/MessageFactory.java
> geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/DtdResolver.java
> {noformat}
> They may be safely deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message