geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3506) LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles fails intermittently with IllegalStateException: Failed to read status file
Date Wed, 23 Aug 2017 21:39:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139181#comment-16139181
] 

ASF GitHub Bot commented on GEODE-3506:
---------------------------------------

GitHub user kirklund opened a pull request:

    https://github.com/apache/geode/pull/738

    GEODE-3506: improve validation/error checking for process file control

    We only ever hit this failure once and I don't think it's a flaky test. This could actually
be one more (last remaining?) root cause of "start locator" or "start server" hanging-while-printing-dots
in GFSH. 
    
    I've added what I consider to be excessive validation and error checking but it should
point us at the cause if this check in FileProcessController ever fails again:
    
        if (isBlank(lines)) {
          throw new IllegalStateException("Status file '" + statusFile + "' is blank");
        }
    
    In addition to this PR, we should consider adding more direct test coverage for ServiceState
and its subclasses as well as more unit tests of the Launcher using mocks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kirklund/geode GEODE-3506-FileProcessController

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #738
    
----
commit 8edd3f0e15406082bb568de975c631de2ae373d7
Author: Kirk Lund <klund@apache.org>
Date:   2017-08-23T21:20:18Z

    GEODE-3506: improve validation and error handling of process file control

----


> LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles fails intermittently
with IllegalStateException: Failed to read status file
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-3506
>                 URL: https://issues.apache.org/jira/browse/GEODE-3506
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh, management
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherRemoteFileIntegrationTest > startDeletesStaleControlFiles
FAILED
>     java.lang.IllegalStateException: Failed to read status file
> {noformat}
> Full stack trace:
> {noformat}
> java.lang.IllegalStateException: Failed to read status file
>         at org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:152)
>         at org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:89)
>         at org.apache.geode.distributed.LocatorLauncher.statusWithWorkingDirectory(LocatorLauncher.java:940)
>         at org.apache.geode.distributed.LocatorLauncher.status(LocatorLauncher.java:868)
>         at org.apache.geode.distributed.LocatorLauncherRemoteIntegrationTestCase.lambda$awaitStart$1(LocatorLauncherRemoteIntegrationTestCase.java:196)
>         at org.awaitility.core.AssertionCondition$1.eval(AssertionCondition.java:55)
>         at org.awaitility.core.ConditionAwaiter$ConditionPoller.run(ConditionAwaiter.java:215)
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>         at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message