geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.
Date Tue, 29 Aug 2017 19:09:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145932#comment-16145932
] 

ASF GitHub Bot commented on GEODE-3472:
---------------------------------------

GitHub user PurelyApplied opened a pull request:

    https://github.com/apache/geode/pull/748

    GEODE-3472: Remove a great deal of commented-out code.

    This pull request replaces #730.
    
    Nontrivial conflicts were introduced after rebasing against GEODE-3436 (`be8a13`).
    
    This pull request includes all suggestions made in #730, as well as a number of other
minor refactorings.
    
    Precheckin running.
    
    -----
    
    * Additionally refactored touched files, driven by suggested changes in a previous pull
request and IDE inspections.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [n/a: refactoring] Have you written or updated unit tests to verify your changes?
    
    - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PurelyApplied/geode geode-3472-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/748.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #748
    
----
commit 4fecf79d76f2caec59f0c8e5afb0744954e5e203
Author: Patrick Rhomberg <prhomberg@pivotal.io>
Date:   2017-08-18T20:59:44Z

    GEODE-3472: Remove a great deal of commented-out code.
    
    * Additionally refactored touched files, driven by suggested changes in a previous pull
request and IDE inspections.

----


> Code Cleanup: remove dead code from /management.
> ------------------------------------------------
>
>                 Key: GEODE-3472
>                 URL: https://issues.apache.org/jira/browse/GEODE-3472
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  This ticket
addresses some of it, limiting scope to those files in `geode-core/**/management/**` to keep
the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message