geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3453) Fix native client function tests to use updated API
Date Thu, 17 Aug 2017 00:43:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129702#comment-16129702
] 

ASF GitHub Bot commented on GEODE-3453:
---------------------------------------

GitHub user dgkimura opened a pull request:

    https://github.com/apache/geode-native/pull/117

    GEODE-3453: Fix native client function tests to use updated API

    Fixes native client built against latest server sources.
    
    https://issues.apache.org/jira/browse/GEODE-254
    
    Testing: Linux built successfully.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dgkimura/geode-native feature/GEODE-3453

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode-native/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
    
----
commit 04ec11e4a69850cae4ad90ac35f5c98d0039252a
Author: David Kimura <dkimura@pivotal.io>
Date:   2017-08-17T00:35:33Z

    GEODE-3453: Fix native client function tests to use updated API

----


> Fix native client function tests to use updated API
> ---------------------------------------------------
>
>                 Key: GEODE-3453
>                 URL: https://issues.apache.org/jira/browse/GEODE-3453
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: David Kimura
>
> Remove deprecated API call in order to build and test against latest server.
> This change broke test code calling into deprecated function: https://issues.apache.org/jira/browse/GEODE-254
> Following diff should be sufficient to fix this issue.
> {noformat}
> diff --git a/src/tests/javaobject/GetFunctionExeHA.java b/src/tests/javaobject/GetFunctionExeHA.java
> index 62216c07..ece5f337 100644
> --- a/src/tests/javaobject/GetFunctionExeHA.java
> +++ b/src/tests/javaobject/GetFunctionExeHA.java
> @@ -35,7 +35,7 @@ public class GetFunctionExeHA extends FunctionAdapter implements Declarable{
>      RegionFunctionContext context = (RegionFunctionContext)fc;
>      System.out.println("Data set :: " + context.getDataSet());
>      Region region = PartitionRegionHelper.getLocalDataForContext(context);
> -    Set keys = region.keys();
> +    Set keys = region.keySet();
>      Iterator itr = keys.iterator();
>      ResultSender sender = context.getResultSender();
>      Object k = null;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message