geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3447) Implement client authorization for the new protocol
Date Mon, 28 Aug 2017 16:51:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143989#comment-16143989
] 

ASF GitHub Bot commented on GEODE-3447:
---------------------------------------

Github user metatype commented on a diff in the pull request:

    https://github.com/apache/geode/pull/719#discussion_r135573704
  
    --- Diff: geode-core/src/main/java/org/apache/geode/security/StreamAuthenticator.java
---
    @@ -46,6 +44,14 @@ void receiveMessage(InputStream inputStream, OutputStream outputStream,
       boolean isAuthenticated();
     
       /**
    +   * Return an authorization object which can be used to determine which permissions
this stream has
    +   * according to the provided securityManager.
    +   *
    +   * Calling this before authentication has succeeded may result in a null return object.
    --- End diff --
    
    `Optional` doesn't really fix the problem, just introduces more GC pressure :-)
    
    Wouldn't it be better to throw `IllegalStateException` when the precondition is not met?


> Implement client authorization for the new protocol
> ---------------------------------------------------
>
>                 Key: GEODE-3447
>                 URL: https://issues.apache.org/jira/browse/GEODE-3447
>             Project: Geode
>          Issue Type: New Feature
>          Components: client/server
>            Reporter: Brian Baynes
>            Assignee: Bruce Schuchardt
>
> As a user of the new client/server protocol, I need to make sure the clients using the
protocol to access my grid are authorized to perform each operation they attempt.
> Implement client authorization for operations in new protocol based on existing authorization
configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message