geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3413) Overhaul launcher tests and process tests
Date Wed, 09 Aug 2017 21:15:02 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120663#comment-16120663
] 

ASF GitHub Bot commented on GEODE-3413:
---------------------------------------

Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132308711
  
    --- Diff: geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTest.java
---
    @@ -47,26 +50,21 @@
     
       @Before
       public void setUp() throws Exception {
    -    this.gemfirePropertiesFile =
    -        this.temporaryFolder.newFile(DistributionConfig.GEMFIRE_PREFIX + "properties");
    +    propertiesFile = temporaryFolder.newFile(GEMFIRE_PREFIX + "properties");
     
    -    this.expectedGemfireProperties = new Properties();
    -    this.expectedGemfireProperties.setProperty(NAME, "memberOne");
    -    this.expectedGemfireProperties.setProperty(GROUPS, "groupOne, groupTwo");
    -    this.expectedGemfireProperties.store(new FileWriter(this.gemfirePropertiesFile, false),
    -        this.testName.getMethodName());
    +    expectedProperties = new Properties();
    +    expectedProperties.setProperty(NAME, "memberOne");
    +    expectedProperties.setProperty(GROUPS, "groupOne, groupTwo");
    +    expectedProperties.store(new FileWriter(propertiesFile, false), testName.getMethodName());
     
    -    assertThat(this.gemfirePropertiesFile).isNotNull();
    -    assertThat(this.gemfirePropertiesFile.exists()).isTrue();
    -    assertThat(this.gemfirePropertiesFile.isFile()).isTrue();
    +    assertThat(propertiesFile).exists().isFile();
       }
     
       @Test
    -  public void testLoadGemFirePropertiesFromFile() throws Exception {
    -    final Properties actualGemFireProperties =
    -        AbstractLauncher.loadGemFireProperties(this.gemfirePropertiesFile.toURI().toURL());
    +  public void loadGemFirePropertiesFromFile() throws Exception {
    +    Properties loadedProperties = loadGemFireProperties(propertiesFile.toURI().toURL());
     
    -    assertThat(actualGemFireProperties).isNotNull();
    -    assertThat(actualGemFireProperties).isEqualTo(this.expectedGemfireProperties);
    +    assertThat(loadedProperties).isEqualTo(expectedProperties);
       }
    +
    --- End diff --
    
    Removed from all classes in change-set.


> Overhaul launcher tests and process tests
> -----------------------------------------
>
>                 Key: GEODE-3413
>                 URL: https://issues.apache.org/jira/browse/GEODE-3413
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>              Labels: LauncherTest, ProcessTest
>
> The launcher and process tests are closely related and in need of overhauling to improve
debugging and remove flakiness.
> In addition, the org.apache.geode.internal.process package is need of improving the test
code coverage.
> Launcher tests:
> * geode-assembly/src/test/java/org/apache/geode/distributed/LocatorLauncherAssemblyIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherServiceStatusTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LauncherMemberMXBeanIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherLocalFileIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherLocalIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteFileIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteWithCustomLoggingIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/LocatorStateTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherLocalFileIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherLocalIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteFileIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteWithCustomLoggingIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteWithCustomLoggingIntegrationTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java
> * geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherWithProviderIntegrationTest.java
> Process tests:
> * geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/LocalProcessControllerJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/LocalProcessLauncherDUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/LocalProcessLauncherJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/NonBlockingProcessStreamReaderJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/PidFileJUnitTest.java
> * geode-core/src/test/java/org/apache/geode/internal/process/ProcessControllerFactoryJUnitTest.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message