geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators
Date Thu, 17 Aug 2017 19:06:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131018#comment-16131018
] 

ASF GitHub Bot commented on GEODE-3406:
---------------------------------------

Github user kohlmu-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/716#discussion_r133782267
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java
---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information
regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version
2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may
obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express
    + * or implied. See the License for the specific language governing permissions and limitations
under
    + * the License.
    + */
    +
    +package org.apache.geode.internal.cache.tier.sockets;
    +
    +import java.io.IOException;
    +import java.net.Socket;
    +import java.util.Iterator;
    +import java.util.ServiceLoader;
    +
    +import org.apache.geode.internal.cache.InternalCache;
    +import org.apache.geode.internal.cache.tier.Acceptor;
    +import org.apache.geode.internal.cache.tier.CachedRegionHelper;
    +import org.apache.geode.internal.security.SecurityService;
    +
    +/**
    + * Creates instances of ServerConnection based on the connection mode provided.
    --- End diff --
    
    I'm not sure that this comment is valid anymore... Something has to be said for not copy-pasting.


> Enable new flow for protocol on locators
> ----------------------------------------
>
>                 Key: GEODE-3406
>                 URL: https://issues.apache.org/jira/browse/GEODE-3406
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Brian Baynes
>            Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message