geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators
Date Thu, 17 Aug 2017 17:45:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130901#comment-16130901
] 

ASF GitHub Bot commented on GEODE-3406:
---------------------------------------

Github user kohlmu-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/716#discussion_r133778501
  
    --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
---
    @@ -392,7 +388,7 @@ public void testLocatorUpdateIntervalZero() throws Exception {
     
       private void startFakeLocator() throws UnknownHostException, IOException, InterruptedException
{
         server = new TcpServer(port, InetAddress.getLocalHost(), null, null, handler, new
FakeHelper(),
    -        Thread.currentThread().getThreadGroup(), "Tcp Server");
    +        Thread.currentThread().getThreadGroup(), "Tcp Server", null);
    --- End diff --
    
    Why is it valid to pass in a 'null' InternalLocator?


> Enable new flow for protocol on locators
> ----------------------------------------
>
>                 Key: GEODE-3406
>                 URL: https://issues.apache.org/jira/browse/GEODE-3406
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Brian Baynes
>            Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message