geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3397) Tomcat client server tests writes 2 locator tags to the cache-client.xml file
Date Fri, 04 Aug 2017 20:32:00 GMT


ASF GitHub Bot commented on GEODE-3397:

Github user DivineEnder commented on the issue:
    @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 

> Tomcat client server tests writes 2 locator tags to the cache-client.xml file
> -----------------------------------------------------------------------------
>                 Key: GEODE-3397
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: http session
>            Reporter: David Anuta
>             Fix For: 1.3.0
> Client server tests for Tomcat 6, 7, and 8 that use Cargo write 2 locator tags to the
cache-client.xml file when it should only write one. Both the default locator (on port 10334)
and the locator that started up are written to the xml file as seen below.
> {noformat}
> <?xml version="1.0" encoding="UTF-8" standalone="no"?><!--
> 	Licensed to the Apache Software Foundation (ASF) under one or more
> 	contributor license agreements.  See the NOTICE file distributed with
> 	this work for additional information regarding copyright ownership.
> 	The ASF licenses this file to You under the Apache License, Version 2.0
> 	(the "License"); you may not use this file except in compliance with
> 	the License.  You may obtain a copy of the License at
> 	Unless required by applicable law or agreed to in writing, software
> 	distributed under the License is distributed on an "AS IS" BASIS,
> 	See the License for the specific language governing permissions and
> 	limitations under the License.
> --><client-cache xmlns="" xmlns:xsi=""
version="1.0" xsi:schemaLocation="">
>   <!-- The default pool connects to a locator running on localhost at
>        port 10334. To connect to a different locator host and port, modify
>        the following pool locator host and port. -->
>   <pool name="sessions" subscription-enabled="true">
>     <locator host="localhost" port="10334"/>
>   <locator host="localhost" port="57621"/></pool>
>   <!-- To configure the client to use a server instead of a locator, replace
>        the locator pool above with the server pool below and modify the server
>        host and port as necessary. -->
>   <!--
>   <pool name="sessions" subscription-enabled="true">
>     <server host="localhost" port="40404"/>
>   </pool>
>   -->
> </client-cache>
> {noformat}
> This bug has to do with the editXMLFile function in the ContainerInstall class. Specifically,
it is caused by the TomcatContainer class not overwriting the default locator tag, but instead
creating a new one. This is due to both a missing parameter in the TomcatContainer class when
calling editXMLFile, and due to the fact that the editXMLFile function does not have a way
to search for a tag by name instead of by id.
> The editXMLFile function needs to be updated to allow for search by tag name and the
editOnSimilarAttributes parameter needs to be passed to the editXMLFile function from the
TomcatContainer class.

This message was sent by Atlassian JIRA

View raw message