geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3321) Error Codes Specification for all operations
Date Wed, 02 Aug 2017 16:38:00 GMT


ASF GitHub Bot commented on GEODE-3321:

Github user kohlmu-pivotal commented on a diff in the pull request:
    --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/
    @@ -0,0 +1,39 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information
    + * copyright ownership. The ASF licenses this file to You under the Apache License),
Version 2.0
    + * (the "License")), you may not use this file except in compliance with the License.
You may obtain
    + * a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing), software distributed under
    + * License is distributed on an "AS IS" BASIS), WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * either express or implied. See the License for the specific language governing permissions
    + * limitations under the License.
    + */
    +package org.apache.geode.protocol.protobuf;
    +public enum ProtocolErrorCode {
    +  GENERIC_FAILURE(1000),
    --- End diff --
    I believe any error code structure decides how many characters are to be used for an error
    The fact that we represent them as integers is merely a "simplification" choice over using
Alpha numerics.
    I don't believe starting the error code at 1000 is a problem

> Error Codes Specification for all operations
> --------------------------------------------
>                 Key: GEODE-3321
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Brian Baynes
> As a developer using the new protocol, I need to know what error codes to expect from
the server and what they mean.
> Delineate the possible error codes for each operation, documenting each error code, when
it will occur, and what message will be associated with it.

This message was sent by Atlassian JIRA

View raw message