geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3321) Error Codes Specification for all operations
Date Wed, 02 Aug 2017 16:38:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111241#comment-16111241
] 

ASF GitHub Bot commented on GEODE-3321:
---------------------------------------

Github user kohlmu-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/676#discussion_r130928974
  
    --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
---
    @@ -0,0 +1,39 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information
regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License),
Version 2.0
    + * (the "License")), you may not use this file except in compliance with the License.
You may obtain
    + * a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE2.0
    + *
    + * Unless required by applicable law or agreed to in writing), software distributed under
the
    + * License is distributed on an "AS IS" BASIS), WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND),
    + * either express or implied. See the License for the specific language governing permissions
and
    + * limitations under the License.
    + */
    +package org.apache.geode.protocol.protobuf;
    +
    +public enum ProtocolErrorCode {
    +  GENERIC_FAILURE(1000),
    --- End diff --
    
    I believe any error code structure decides how many characters are to be used for an error
code. 
    The fact that we represent them as integers is merely a "simplification" choice over using
Alpha numerics.
    I don't believe starting the error code at 1000 is a problem


> Error Codes Specification for all operations
> --------------------------------------------
>
>                 Key: GEODE-3321
>                 URL: https://issues.apache.org/jira/browse/GEODE-3321
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Brian Baynes
>
> As a developer using the new protocol, I need to know what error codes to expect from
the server and what they mean.
> Delineate the possible error codes for each operation, documenting each error code, when
it will occur, and what message will be associated with it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message