geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3306) Parsing of cache.xml with whitespace fails with Apache Xerces
Date Thu, 03 Aug 2017 16:05:00 GMT


ASF GitHub Bot commented on GEODE-3306:

Github user darrenfoong commented on the issue:
    I just realised I'll need to unset the property to prevent any side effects in the other
tests; working on it now.

> Parsing of cache.xml with whitespace fails with Apache Xerces
> -------------------------------------------------------------
>                 Key: GEODE-3306
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: management
>    Affects Versions: 1.2.0
>            Reporter: Darren Foong
>            Priority: Minor
>             Fix For: 1.2.0
> I am using Geode 1.2.0 and Apache Xerces 2.11.0 (not the one included in the Oracle JDK),
and I encountered the following error when I tried to programmatically start a cache:
> {noformat}
> org.apache.geode.InternalGemFireError: Did not expected a java.lang.StringBuffer on top
of the stack.
> Exception in thread "main" org.apache.geode.InternalGemFireError: Did not expected a
java.lang.StringBuffer on top of the stack.
> 	at org.apache.geode.internal.Assert.throwError(
> 	at org.apache.geode.internal.Assert.assertTrue(
> 	at org.apache.geode.internal.cache.xmlcache.CacheXmlParser.endRegionAttributes(
> 	at org.apache.geode.internal.cache.xmlcache.CacheXmlParser.endElement(
> 	at org.apache.geode.internal.cache.xmlcache.CacheXmlParser$DefaultHandlerDelegate.endElement(
> 	at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown Source)
> 	at org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown Source)
> 	at org.apache.xerces.impl.xs.XMLSchemaValidator.emptyElement(Unknown Source)
> 	at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source)
> 	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
> 	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
> 	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
> 	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
> 	at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
> 	at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
> 	at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
> 	at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source)
> 	at javax.xml.parsers.SAXParser.parse(
> 	at org.apache.geode.internal.cache.xmlcache.CacheXmlParser.parse(
> 	at org.apache.geode.internal.cache.GemFireCacheImpl.loadCacheXml(
> 	at org.apache.geode.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(
> 	at org.apache.geode.internal.cache.GemFireCacheImpl.initialize(
> 	at org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(
> 	at org.apache.geode.internal.cache.GemFireCacheImpl.create(
> 	at org.apache.geode.cache.CacheFactory.create(
> 	at org.apache.geode.cache.CacheFactory.create(
> 	at server.ServerWhitespace.main(
> {noformat}
> However, this does not happen when I don't use Apache Xerces, i.e. I rely on the version
in the Oracle JDK (1.8).
> After getting the Geode source code and stepping through the parsing using the Eclipse
debugger, I realised that there were unexpected StringBuffers pushed onto the parse stack,
thus causing the problem.
> These StringBuffers were created and pushed by the {{characters()}} method (
Changing the log level to {{TRACE}} and examining the parse stack showed that these StringBuffers
contained the whitespace (including newlines) between the XML tags in {{cache.xml}}.
> When using the Oracle JDK's version of Xerces, these StringBuffers did not appear on
the parse stack despite the whitespace.
> I have a proof of concept on GitHub:
The {{cache.xml}} file without whitespace between the tags was parsed without errors by both
versions of Xerces.
> It could be the case that the JDK Xerces strips out whitespace while Apache Xerces doesn't;
but this could be implemented in {{characters()}} by only pushing non-whitespace char arrays
in the {{else}} block. However, there could be other XML parsing edge cases that I am unaware
> There should be others who need Apache Xerces for their projects; a fix would be appreciated.

This message was sent by Atlassian JIRA

View raw message