geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3269) Refactor ShellCommands
Date Fri, 11 Aug 2017 23:23:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124253#comment-16124253
] 

ASF GitHub Bot commented on GEODE-3269:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/709

    GEODE-3269: Refactoring ShellCommands

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3269)
    
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes? (See [GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359))
    
    **Testing progress: Precheckin in progress! See eyeh-geode-3269 because I probably won't
be able to**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3269

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/709.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #709
    
----
commit 8a06b768b6e928ab3df6ec1ec4c6460141992bec
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-08-11T23:17:42Z

    GEODE-3269: Refactoring ShellCommands

----


> Refactor ShellCommands
> ----------------------
>
>                 Key: GEODE-3269
>                 URL: https://issues.apache.org/jira/browse/GEODE-3269
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> {{ShellCommands.java}} is a large class that contains multiple commands. Each command
should be refactored into a separate class, and the methods shared by the commands should
be refactored into a new and appropriately named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message