geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3268) Refactor RegionCommands
Date Mon, 07 Aug 2017 22:52:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117492#comment-16117492
] 

ASF GitHub Bot commented on GEODE-3268:
---------------------------------------

Github user PurelyApplied commented on a diff in the pull request:

    https://github.com/apache/geode/pull/693#discussion_r131776451
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DescribeRegionCommand.java
---
    @@ -359,7 +272,7 @@ private boolean writeFixedPartitionAttributesToTable(TabularResultData
table,
             fpaBuilder.append(fpa.getNumBuckets());
     
             if (!isTypeAdded) {
    -          type = attributeType;
    +          type = "";
    --- End diff --
    
    I agree with the removal of a constant parameter, but in this case, we're not distinguishing
between `type = "";` here vs `type = blank; // = ""` a few lines below. 
     These could be removed altogether, with `""` passed directly to the `writeAttributeToTable`
call at the end of this method.


> Refactor RegionCommands
> -----------------------
>
>                 Key: GEODE-3268
>                 URL: https://issues.apache.org/jira/browse/GEODE-3268
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> {{RegionCommands.java}} is a large class that contains multiple commands. Each command
should be refactored into a separate class, and the methods shared by the commands should
be refactored into a new and appropriately named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message