geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3267) Refactor QueueCommands
Date Mon, 07 Aug 2017 21:50:00 GMT


ASF GitHub Bot commented on GEODE-3267:

GitHub user YehEmily opened a pull request:

    GEODE-3267: Refactoring QueueCommands

    [View the JIRA ticket here.](
    `QueueCommands` was a big class that contained two commands (each class should only contain
one). These commands have been split into their own individual command classes.
    **TESTING STATUS: Precheckin in progress**
    - [x] JIRA ticket referenced
    - [x] PR rebased
    - [x] Initial commit is single and squashed
    - [x] `gradlew build` runs cleanly
    - [ ] Unit tests will be updated with [GEODE-1359](

You can merge this pull request into a Git repository by running:

    $ git pull GEODE-3267

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #695
commit 48f6616ea10cf2ae0bdea9f698b6531d35018ff4
Author: YehEmily <>
Date:   2017-08-07T21:47:15Z

    GEODE-3267: Refactoring QueueCommands


> Refactor QueueCommands
> ----------------------
>                 Key: GEODE-3267
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
> {{}} is a large class that contains multiple commands. Each command
should be refactored into a separate class, and the methods shared by the commands should
be refactored into a new and appropriately named class of their own.

This message was sent by Atlassian JIRA

View raw message