geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3260) Refactor FunctionCommands
Date Mon, 07 Aug 2017 23:29:00 GMT


ASF GitHub Bot commented on GEODE-3260:

Github user PurelyApplied commented on the issue:
    A far-from-critical nitpick: there are several places in `ExecuteFunctionCommand` and
one in `DestroyFunctionCommand` that are of the form
        result = ResultBuilder.[...];
        return result;
    In other instances, the result is returned directly
       return ResultBuilder.[...];
    I'd change those few assign-and-immediately-return to just return the object directly.
 You might then be able to delete the declaration of the variable as well.

> Refactor FunctionCommands
> -------------------------
>                 Key: GEODE-3260
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
> {{}} is a large class that contains multiple commands. Each command
should be refactored into a separate class, and the methods shared by the commands should
be refactored into a new and appropriately named class of their own.

This message was sent by Atlassian JIRA

View raw message