geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3257) Refactor DeployCommands
Date Thu, 03 Aug 2017 00:38:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111980#comment-16111980
] 

ASF GitHub Bot commented on GEODE-3257:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/680

    GEODE-3257: Refactoring DeployCommands

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3257)
    
    **Testing Status: Precheckin to be run on morning of 8/3**
    
    - [x] JIRA ticket
    
    - [x] PR rebased
    
    - [x] Commit single & squashed
    
    - [x] `gradlew build` runs cleanly
    
    - [ ] Tests to be updated with [GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3257

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #680
    
----
commit db50d331c54ec4c8ed7f583685c78002c91c7bde
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-08-03T00:28:10Z

    GEODE-3257: Refactoring DeployCommands

----


> Refactor DeployCommands
> -----------------------
>
>                 Key: GEODE-3257
>                 URL: https://issues.apache.org/jira/browse/GEODE-3257
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> {{DeployCommands.java}} is a large class that contains multiple commands. Each command
should be refactored into a separate class, and the methods shared by the commands should
be refactored into a new and appropriately named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message