geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3254) Refactor ConfigCommands
Date Tue, 01 Aug 2017 16:46:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109268#comment-16109268
] 

ASF GitHub Bot commented on GEODE-3254:
---------------------------------------

Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/665#discussion_r130658877
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java
---
    @@ -0,0 +1,79 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information
regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version
2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may
obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express
    + * or implied. See the License for the specific language governing permissions and limitations
under
    + * the License.
    + */
    +
    +package org.apache.geode.management.internal.cli.commands;
    +
    +import java.io.File;
    +import java.io.IOException;
    +import java.nio.file.Path;
    +import java.util.Map;
    +
    +import org.apache.geode.management.cli.Result;
    +import org.apache.geode.management.internal.cli.AbstractCliAroundInterceptor;
    +import org.apache.geode.management.internal.cli.GfshParseResult;
    +import org.apache.geode.management.internal.cli.i18n.CliStrings;
    +import org.apache.geode.management.internal.cli.result.ResultBuilder;
    +import org.apache.geode.management.internal.cli.shell.Gfsh;
    +
    +/**
    + * Interceptor used by gfsh to intercept execution of export config command at "shell".
    + */
    +public class Interceptor extends AbstractCliAroundInterceptor {
    --- End diff --
    
    This class appears to be unused.


> Refactor ConfigCommands
> -----------------------
>
>                 Key: GEODE-3254
>                 URL: https://issues.apache.org/jira/browse/GEODE-3254
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> {{ConfigCommands.java}} is a large class that contains multiple commands. Each command
should be refactored into a separate class, and the methods shared by the commands should
be refactored into a new and appropriately named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message