geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3230) Delete unused commands in CliStrings
Date Wed, 02 Aug 2017 18:36:01 GMT


ASF GitHub Bot commented on GEODE-3230:

Github user YehEmily commented on a diff in the pull request:
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/
    @@ -99,7 +99,6 @@ protected Launcher() {
    -    this.allowedCommandLineCommands.add(CliStrings.START_MANAGER);
    --- End diff --
    Sure! Almost none of the `--- manager` CliStrings were used, so I deleted them. Only `start
manager` was ever used, and only in this place, so I figured it would be safe to get rid of
it. Do you think this might break any backwards compatibility / should I roll back the change?

> Delete unused commands in CliStrings
> ------------------------------------
>                 Key: GEODE-3230
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
> There are a lot of commands in {{CliStrings}} that aren't used. For example, {{start
manager}} has a whole set of associated commands - {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}},
{{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere. These commands should
be deleted to clean up the code.

This message was sent by Atlassian JIRA

View raw message