geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3230) Delete unused commands in CliStrings
Date Tue, 01 Aug 2017 17:50:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109401#comment-16109401
] 

ASF GitHub Bot commented on GEODE-3230:
---------------------------------------

Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/651#discussion_r130677475
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/Launcher.java
---
    @@ -99,7 +99,6 @@ protected Launcher() {
         this.allowedCommandLineCommands.add(CliStrings.START_JCONSOLE);
         this.allowedCommandLineCommands.add(CliStrings.START_JVISUALVM);
         this.allowedCommandLineCommands.add(CliStrings.START_LOCATOR);
    -    this.allowedCommandLineCommands.add(CliStrings.START_MANAGER);
    --- End diff --
    
    Can you explain the reason this change?


> Delete unused commands in CliStrings
> ------------------------------------
>
>                 Key: GEODE-3230
>                 URL: https://issues.apache.org/jira/browse/GEODE-3230
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> There are a lot of commands in {{CliStrings}} that aren't used. For example, {{start
manager}} has a whole set of associated commands - {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}},
{{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere. These commands should
be deleted to clean up the code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message