geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2842) Remove unnecessary @CliOption arguments
Date Fri, 25 Aug 2017 22:53:01 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142379#comment-16142379
] 

ASF GitHub Bot commented on GEODE-2842:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/731


> Remove unnecessary @CliOption arguments
> ---------------------------------------
>
>                 Key: GEODE-2842
>                 URL: https://issues.apache.org/jira/browse/GEODE-2842
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>
> The {{@CliOption}} annotation specifies default values for some of its fields (like {{mandatory}}
and {{unspecifiedDefaultValue}}).  Yet, we often explicitly set those fields to the default
value.  For example,
> {noformat}      @CliOption(key = CliStrings.START_LOCATOR__MEMBER_NAME, mandatory = false,
>           unspecifiedDefaultValue = CliMetaData.ANNOTATION_NULL_VALUE,
>           help = CliStrings.START_LOCATOR__MEMBER_NAME__HELP) String memberName {noformat}
> could simply read   
> {noformat}      @CliOption(key = CliStrings.START_LOCATOR__MEMBER_NAME,
>           help = CliStrings.START_LOCATOR__MEMBER_NAME__HELP) String memberName {noformat}
> Removing these redundant/unnecessary arguments will make the code a lot more readable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message