geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-2729) Improve Native Client Stability by removing global variables
Date Mon, 07 Aug 2017 20:48:00 GMT


ASF GitHub Bot commented on GEODE-2729:

GitHub user dgkimura opened a pull request:

    GEODE-2729: Remove global variables

    - Remove CacheImpl::getInstance calls
    - Converted PdxTypeRegistry clear to non-static method
    - Adding Type Registry to cpp code as a public object.
    - Convert static PoolManager method calls into instance method calls
    - Remove PoolFactory/PoolManager global connectionPool singleton
    - Allows multiple PoolFactories per Cache
    - Remove default pool logic from Cache into PoolManager
    - Add mutli-cache integration test
    All c++ and .NET integration tests passed.  All unittests passed.

You can merge this pull request into a Git repository by running:

    $ git pull feature/GEODE-2740

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #114


> Improve Native Client Stability by removing global variables
> ------------------------------------------------------------
>                 Key: GEODE-2729
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Addison
> *Context*
> Today, the native client uses singleton global variables to manage things like the cache.
 These prove troublesome when moving between managed and unmanaged code. Another benefit of
moving away from the globals is improved unit testing.  This will increase the overall testing
feedback loop.
> *Goal*
> Remove these singletons in favor non-global constructors, destructors, etc.
> Improved stability when calling functions that move between managed and unmanaged code.
> *Definition of Done*
> Remove all integration tests in favor of well encapsulated unit tests.

This message was sent by Atlassian JIRA

View raw message