Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Thu, 20 Jul 2017 23:02:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13087641.1500310877000.297576.1500591720381@Atlassian.JIRA>
In-Reply-To: <JIRA.13087641.1500310877000@Atlassian.JIRA>
References: <JIRA.13087641.1500310877000@Atlassian.JIRA> <JIRA.13087641.1500310877428@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3213) Refactor Protobuf Serialization
 Implemenation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 20 Jul 2017 23:02:06 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095520#comment-16095520 ] 

ASF GitHub Bot commented on GEODE-3213:
---------------------------------------

Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/646#discussion_r128649345
  
    --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java ---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
    + * or implied. See the License for the specific language governing permissions and limitations under
    + * the License.
    + */
    +
    +package org.apache.geode.protocol.protobuf;
    +
    +import org.apache.geode.protocol.operations.OperationHandler;
    +
    +import java.util.function.Function;
    +
    +public class OperationContext<OperationReq, OperationResponse> {
    +  private OperationHandler<OperationReq, OperationResponse> operationHandler;
    --- End diff --
    
    These could be public final and the getters removed. `getFromRequest` and `getToResponse` make it sound like the builder is doing something, when all it's doing is returning an imutable final field.


> Refactor Protobuf Serialization Implemenation
> ---------------------------------------------
>
>                 Key: GEODE-3213
>                 URL: https://issues.apache.org/jira/browse/GEODE-3213
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server, serialization
>            Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we want to make:
> * OperationHandlers take OperationRequest and OperationResponse message, not the parent Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow. No bespoke flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract OperationRequest from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate OperationResponse in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error codes


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)