Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Thu, 20 Jul 2017 16:27:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13087641.1500310877000.293706.1500568020248@Atlassian.JIRA>
In-Reply-To: <JIRA.13087641.1500310877000@Atlassian.JIRA>
References: <JIRA.13087641.1500310877000@Atlassian.JIRA> <JIRA.13087641.1500310877428@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3213) Refactor Protobuf Serialization
 Implemenation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 20 Jul 2017 16:27:10 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094916#comment-16094916 ] 

ASF GitHub Bot commented on GEODE-3213:
---------------------------------------

Github user kohlmu-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/646#discussion_r128386349
  
    --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java ---
    @@ -124,20 +128,19 @@ public void test_RegionThrowsClasscastException() throws CodecAlreadyRegisteredF
         when(regionMock.put(any(), any())).thenThrow(ClassCastException.class);
     
         PutRequestOperationHandler operationHandler = new PutRequestOperationHandler();
    -    ClientProtocol.Response response =
    +    Result<RegionAPI.PutResponse> result =
             operationHandler.process(serializationServiceStub, generateTestRequest(), cacheStub);
     
    -    Assert.assertEquals(ClientProtocol.Response.ResponseAPICase.ERRORRESPONSE,
    -        response.getResponseAPICase());
    +    Assert.assertTrue(result instanceof Failure);
    --- End diff --
    
    Do we need to assert at the error message


> Refactor Protobuf Serialization Implemenation
> ---------------------------------------------
>
>                 Key: GEODE-3213
>                 URL: https://issues.apache.org/jira/browse/GEODE-3213
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server, serialization
>            Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we want to make:
> * OperationHandlers take OperationRequest and OperationResponse message, not the parent Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow. No bespoke flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract OperationRequest from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate OperationResponse in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error codes


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)