Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Wed, 12 Jul 2017 16:59:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13086636.1499878303000.230305.1499878740046@Atlassian.JIRA>
In-Reply-To: <JIRA.13086636.1499878303000@Atlassian.JIRA>
References: <JIRA.13086636.1499878303000@Atlassian.JIRA> <JIRA.13086636.1499878303790@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3194) Cleanup disk store on failed
 recovery
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 12 Jul 2017 16:59:09 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084299#comment-16084299 ] 

ASF GitHub Bot commented on GEODE-3194:
---------------------------------------

GitHub user nreich opened a pull request:

    https://github.com/apache/geode/pull/627

    GEODE-3194: cleanup disk store on failed initial recovery

    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [x] Have you written or updated unit tests to verify your changes?
    
    - [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nreich/geode feature/GEODE-3194

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/627.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #627
    
----
commit dc59af8721654a6fcaff3ad0bce80e390746fab3
Author: Nick Reich <nreich@pivotal.io>
Date:   2017-07-12T16:54:07Z

    GEODE-3194: cleanup disk store on failed initial recovery

----


> Cleanup disk store on failed recovery
> -------------------------------------
>
>                 Key: GEODE-3194
>                 URL: https://issues.apache.org/jira/browse/GEODE-3194
>             Project: Geode
>          Issue Type: Bug
>          Components: persistence
>            Reporter: Nick Reich
>            Assignee: Nick Reich
>             Fix For: 1.3.0
>
>
> When recovering from persistent disk stores, it is possible to have the process fail exceptionally (for example, a failure deserializing the data from the disk store). Currently, however, this is not handled in a way that cleans up the partially setup disk store, but should be modified to do so.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)