geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3213) Refactor Protobuf Serialization Implemenation
Date Fri, 21 Jul 2017 17:04:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096527#comment-16096527
] 

ASF GitHub Bot commented on GEODE-3213:
---------------------------------------

Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/646#discussion_r128811551
  
    --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
    @@ -35,10 +37,9 @@
        * @param errorMessage - description of the error
        * @return An error response containing the above parameters
        */
    -  public static ClientProtocol.Response createErrorResponse(String errorMessage) {
    -    ClientProtocol.ErrorResponse error =
    -        ClientProtocol.ErrorResponse.newBuilder().setMessage(errorMessage).build();
    -    return ClientProtocol.Response.newBuilder().setErrorResponse(error).build();
    +  public static Failure createFailureResult(String errorMessage) {
    --- End diff --
    
    @pivotal-amurmann @kohlmu-pivotal Did this get addressed?


> Refactor Protobuf Serialization Implemenation
> ---------------------------------------------
>
>                 Key: GEODE-3213
>                 URL: https://issues.apache.org/jira/browse/GEODE-3213
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server, serialization
>            Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we want to
make:
> * OperationHandlers take OperationRequest and OperationResponse message, not the parent
Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow. No bespoke
flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract OperationRequest
from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate OperationResponse
in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error codes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message