geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3213) Refactor Protobuf Serialization Implemenation
Date Fri, 21 Jul 2017 03:50:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095736#comment-16095736
] 

ASF GitHub Bot commented on GEODE-3213:
---------------------------------------

Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/646#discussion_r128678978
  
    --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
    @@ -124,20 +128,19 @@ public void test_RegionThrowsClasscastException() throws CodecAlreadyRegisteredF
         when(regionMock.put(any(), any())).thenThrow(ClassCastException.class);
     
         PutRequestOperationHandler operationHandler = new PutRequestOperationHandler();
    -    ClientProtocol.Response response =
    +    Result<RegionAPI.PutResponse> result =
             operationHandler.process(serializationServiceStub, generateTestRequest(), cacheStub);
     
    -    Assert.assertEquals(ClientProtocol.Response.ResponseAPICase.ERRORRESPONSE,
    -        response.getResponseAPICase());
    +    Assert.assertTrue(result instanceof Failure);
    --- End diff --
    
    no. Is it worth asserting part of it?


> Refactor Protobuf Serialization Implemenation
> ---------------------------------------------
>
>                 Key: GEODE-3213
>                 URL: https://issues.apache.org/jira/browse/GEODE-3213
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server, serialization
>            Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we want to
make:
> * OperationHandlers take OperationRequest and OperationResponse message, not the parent
Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow. No bespoke
flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract OperationRequest
from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate OperationResponse
in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error codes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message