geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3192) PutAll on new protocol informs client which keys couldn't be inserted
Date Tue, 18 Jul 2017 23:05:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092301#comment-16092301
] 

ASF GitHub Bot commented on GEODE-3192:
---------------------------------------

GitHub user WireBaron opened a pull request:

    https://github.com/apache/geode/pull/643

    GEODE-3192,GEODE-3229: Change API and implementation of protobuf PutAll.

    @kohlmu-pivotal @pivotal-amurmann @galen-pivotal @bschuchardt @hiteshk25 
    
    * We will now dispatch incoming protobuf PutAlls as a series of put operations
    * The PutAllResponse will contain a set of failed keys and the error they failed with
    
    Signed-off-by: Galen O'Sullivan <gosullivan@pivotal.io>
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [x] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WireBaron/geode feature/GEODE-3229

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/643.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #643
    
----
commit a056814b30f76572dca68abea57895d4be670da2
Author: Brian Rowe <browe@pivotal.io>
Date:   2017-07-18T21:52:50Z

    GEODE-3192,GEODE-3229: Change API and implementation of protobuf PutAll.
    
    * We will now dispatch incoming protobuf PutAlls as a series of put operations
    * The PutAllResponse will contain a set of failed keys and the error they failed with
    
    Signed-off-by: Galen O'Sullivan <gosullivan@pivotal.io>
    Signed-off-by: Brian Rowe <browe@pivotal.io>

----


> PutAll on new protocol informs client which keys couldn't be inserted
> ---------------------------------------------------------------------
>
>                 Key: GEODE-3192
>                 URL: https://issues.apache.org/jira/browse/GEODE-3192
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Alexander Murmann
>
> When a putAll request fails to insert a given key/value pair the corresponding response
will contain information about which keys/values failed to be inserted.
> *Note:* We left this out of GEODE-2997 which initially introduces putAll because we want
to get something to test with early.
> *Implementation Note:* The new protocol uses Region#putAll which returns void, but the
old protocol uses basicBridgePutAll, which we don't understand but which seems to give more
information. Having a look at the old protocol's putAll command could be useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message