geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Darrel Schneider (JIRA)" <>
Subject [jira] [Commented] (GEODE-3187) CI failure (windows): org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest.testIncrementalBackupScript
Date Mon, 17 Jul 2017 23:18:00 GMT


Darrel Schneider commented on GEODE-3187:

This failure revealed a couple of problems with the Windows specific backup code.
1. The BackupInspectionJUnitTest hard codes the contents of the restore scripts in a couple
of java String constants. These String have diverged and no longer contain restore scripts
that geode backup command will generate. The ones that are wrong are:
Both of them contain "xcopy" and "copy" but the backup code now uses "robocopy" instead.

2. The method: org.apache.geode.internal.cache.persistence.WindowsBackupInspector.parseOplogLines(BufferedReader)
ask this: line.startsWith("robocopy")
But the code that generates these lines add this to the start of a line: "C:\\Windows\\System32\\Robocopy.exe".
So it is never going to find "robocopy" and this will cause the inspector to never detect
an incremental backup.
I think instead of looking for lines that start with "robocopy" it should just skip lines
that start with "IF" and break if it contains EXIT_MARKER (it already does both of these).
For any other line it should extract the oplog file name. This is basically what it does for
3. It seems wrong for the backup command to generate "C:\\Windows\\System32\\Robocopy.exe".
I could be wrong but I doubt that robocopy will always be in this location. It seems like
we should all a search to be done for it in which case the generate code would just start
the command line with "robocopy".

> CI failure (windows): org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest.testIncrementalBackupScript
> ----------------------------------------------------------------------------------------------------------------------
>                 Key: GEODE-3187
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: persistence
>            Reporter: Lynn Gallinat
> {noformat}
> org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest > testIncrementalBackupScript
>     java.lang.AssertionError
>         at
>         at org.junit.Assert.assertTrue(
>         at org.junit.Assert.assertTrue(
>         at org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest.testIncrementalBackupScript(
> {noformat}

This message was sent by Atlassian JIRA

View raw message