geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-3129) Add error messages for new protocol clients
Date Fri, 07 Jul 2017 20:31:00 GMT


ASF subversion and git services commented on GEODE-3129:

Commit 0ce62710d7b85e24ea57f11b9064a774735f182f in geode's branch refs/heads/develop from
[;h=0ce6271 ]

GEODE-3129 - Added error messages to protobuf protocol. This now closes #621

added a new ErrorResponse type to ClientProtocol
removed success field from several RegionAPI response objects and refactored operation handlers
to instead return ErrorResponses
made all op handlers take ClientProtocol.Requests and return ClientProtocol.Responses instead
of operation specific types
moved the protobuf specific response building code from operation handlers to ProtobufResponseUtilities
moved the request building functions from MessageUtil (under Test) to ProtobufRequestUtilities
moved all utility classes to ...protocol.protobuf.utilities and added javadoc comments throughout
changed GetRegions to GetRegionNames, returns strings instead of Regions
replaced logging through the cache's LogWriter with log4j logging
updated all imports to be in the correct order for the new geode style guide

Signed-off-by: Brian Rowe <>
Signed-off-by: Hitesh Khamesra <>
Signed-off-by: Brian Rowe <>

> Add error messages for new protocol clients
> -------------------------------------------
>                 Key: GEODE-3129
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Brian Baynes
> Users of new protocol need helpful messages when the protocol encounters an error.  Using
feedback from initial testers of the protocol, add helpful error messages to existing operations,
setting precedent for operations still to come.
> The user should be able to distinguish between:
> - Programming mistakes on part of client
> - Retry-able errors
> - Server-side errors (e.g., misconfiguration, OOM, cluster issues, etc)
> Error messages should not include sensitive data (e.g., keys or values).

This message was sent by Atlassian JIRA

View raw message