geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3031) Extract startLocator and startServer from LauncherLifecycleCommands
Date Tue, 18 Jul 2017 21:35:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092225#comment-16092225
] 

ASF GitHub Bot commented on GEODE-3031:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/642

    GEODE-3031: Extracting startLocator and startServer from LauncherLifecycleCommands

    [See the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3031?jql=project%20%3D%20GEODE%20AND%20text%20~%20%22launcherlifecyclecommands%22)
    
    `LauncherLifecycleCommands.java` was a huge class that contained commands for starting
a server (`startServer`) and for starting a locator (`startLocator`). As a result, these gfsh
commands were extracted. Then, the other methods associated with these two gfsh commands were
refactored and moved to other classes.
    
    **Testing Progress:** Precheckin running
    
    - [x] JIRA ticket associated with this PR is referenced in the commit message
    
    - [x] PR has been rebased against the latest commit within the target branch
    
    - [x] Initial contribution is a single, squashed commit
    
    - [x] `gradlew build` runs cleanly
    
    - [x] Wrote/updated unit tests to verify changes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3031

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/642.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #642
    
----
commit e37930172e46d36433ba2c479d04ed69a7a16902
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-07-17T21:35:50Z

    GEODE-3031: Extracting startLocator and startServer from LauncherLifecycleCommands, removing
the entire LauncherLifecycleCommands class, and moving tests from LauncherLifecycleCommandsTest
to GfshCommandTest, StartServerCommands, and StartLocatorCommands

----


> Extract startLocator and startServer from LauncherLifecycleCommands
> -------------------------------------------------------------------
>
>                 Key: GEODE-3031
>                 URL: https://issues.apache.org/jira/browse/GEODE-3031
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Jared Stewart
>            Assignee: Emily Yeh
>
> LauncherLifecycleCommands is a huge class that contains both startServer and startLocator.
 We ought to extract those command methods into their own classes, and figure out a sensible
home for the shared, common methods from LauncherLifecycleCommands used by both commands.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message