geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2997) New flow: putAll/getAll
Date Wed, 26 Jul 2017 16:36:01 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101891#comment-16101891
] 

ASF GitHub Bot commented on GEODE-2997:
---------------------------------------

Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/649#discussion_r129626228
  
    --- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
    @@ -66,7 +66,7 @@ message Response {
             RemoveAllResponse removeAllResponse = 7;
             ListKeysResponse listKeysResponse = 8;
     
    -        ErrorResponse errorResponse = 13;
    +        Error error = 13;
    --- End diff --
    
    The reasoning is, we're not just using it as an ErrorResponse at the same level as a PutResponse
or GetResponse -- it gets embedded in other responses now.


> New flow: putAll/getAll
> -----------------------
>
>                 Key: GEODE-2997
>                 URL: https://issues.apache.org/jira/browse/GEODE-2997
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Brian Baynes
>
> Create proto message definitions and op handler for putAll/getAll messages.
> Client should be able to complete putAll/getAll of primitives and JSON with response.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message