geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-2860) refactor EventTracker to be on DistributedRegion instead of LocalRegion
Date Fri, 14 Jul 2017 17:33:00 GMT


ASF GitHub Bot commented on GEODE-2860:

Github user nreich closed the pull request at:

> refactor EventTracker to be on DistributedRegion instead of LocalRegion
> -----------------------------------------------------------------------
>                 Key: GEODE-2860
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: regions
>            Reporter: Darrel Schneider
>            Assignee: Nick Reich
>              Labels: storage_3
> Currently LocalRegion has a non-final field named "eventTracker". It is initialized in
a method named createEventTracker which does nothing on LocalRegion but is implemented on
DistributedRegion and BucketRegion to initialize the eventTracker field.
> I think things would be clearer if this field was moved to DistributedRegion.
> All the code on LocalRegion that currently tests for a non-null eventTracker can be changed
to do nothing and overridden on DistributedRegion to use its eventTracker. DistributedRegion
can make this field final and always set it in its constructor. Since BucketRegion extends
DistributedRegion it does not to do anything (it currently implements createEventTracker but
that was not needed since it inherits the same impl from DistributedRegion).

This message was sent by Atlassian JIRA

View raw message