geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-2860) refactor EventTracker to be on DistributedRegion instead of LocalRegion
Date Wed, 12 Jul 2017 18:51:00 GMT


ASF subversion and git services commented on GEODE-2860:

Commit 0e215d4ba961abb7dd293662a7586aacf2369f00 in geode's branch refs/heads/feature/GEODE-2860
from [~nreich]
[;h=0e215d4 ]

GEODE-2860: Refactor use of EventTracker

  * change EventTracker to an interface with two implementations
  * move as much logic out of LocalRegion down into subclasses that
    make use EventTracker
  * move and refactor static inner classes in EventTracker into own
    class files
  * migrate some of event-focused classes into a new sub package
  * add tests for existing logic from EventTracker

> refactor EventTracker to be on DistributedRegion instead of LocalRegion
> -----------------------------------------------------------------------
>                 Key: GEODE-2860
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: regions
>            Reporter: Darrel Schneider
>            Assignee: Nick Reich
>              Labels: storage_3
> Currently LocalRegion has a non-final field named "eventTracker". It is initialized in
a method named createEventTracker which does nothing on LocalRegion but is implemented on
DistributedRegion and BucketRegion to initialize the eventTracker field.
> I think things would be clearer if this field was moved to DistributedRegion.
> All the code on LocalRegion that currently tests for a non-null eventTracker can be changed
to do nothing and overridden on DistributedRegion to use its eventTracker. DistributedRegion
can make this field final and always set it in its constructor. Since BucketRegion extends
DistributedRegion it does not to do anything (it currently implements createEventTracker but
that was not needed since it inherits the same impl from DistributedRegion).

This message was sent by Atlassian JIRA

View raw message