Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Tue, 27 Jun 2017 05:01:07 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13079906.1497479764000.112002.1498539667042@Atlassian.JIRA>
In-Reply-To: <JIRA.13079906.1497479764000@Atlassian.JIRA>
References: <JIRA.13079906.1497479764000@Atlassian.JIRA> <JIRA.13079906.1497479764509@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3075) Bifurcate ServerConnection, create
 factory and feature toggle
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 27 Jun 2017 05:01:17 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064268#comment-16064268 ] 

ASF subversion and git services commented on GEODE-3075:
--------------------------------------------------------

Commit e62e825090db50f77faaa3e222595ee1026d7a6c in geode's branch refs/heads/feature/GEM-1483 from [~gosullivan]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e62e825 ]

GEODE-3075: fix an integration test.

I think the test fails because another test doesn't clean up system
properties when it's done.


> Bifurcate ServerConnection, create factory and feature toggle
> -------------------------------------------------------------
>
>                 Key: GEODE-3075
>                 URL: https://issues.apache.org/jira/browse/GEODE-3075
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Galen O'Sullivan
>            Assignee: Galen O'Sullivan
>             Fix For: 1.3.0
>
>
> Make a factory that creates instances of the new subclasses of {{ServerConnection}} : {{NewClientServerConnection}} and {{LegacyServerConnection}}. This will be the basis for future refactors. This should involve minimal changes to {{AcceptorImpl}} and a minimal implementation of {{NewClientServerConnection}}. All the existing functionality of {{ServerConnection}} must still work.
> To do this, we will need a feature toggle so that the new client protocol (which will now be in a broken state) never gets run in production, but can be enabled for testing. This should probably be set via a hidden system property and not through any config that is a part of the public API.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)