Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B71BD200CB3 for ; Mon, 26 Jun 2017 18:27:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B6248160BF8; Mon, 26 Jun 2017 16:27:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 10E29160BD9 for ; Mon, 26 Jun 2017 18:27:02 +0200 (CEST) Received: (qmail 6645 invoked by uid 500); 26 Jun 2017 16:27:02 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 6636 invoked by uid 99); 26 Jun 2017 16:27:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jun 2017 16:27:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E075B1A7B51 for ; Mon, 26 Jun 2017 16:27:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Tjupm3B5dOpr for ; Mon, 26 Jun 2017 16:27:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0A0CD5FDE4 for ; Mon, 26 Jun 2017 16:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9627BE0363 for ; Mon, 26 Jun 2017 16:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 53B2E24101 for ; Mon, 26 Jun 2017 16:27:00 +0000 (UTC) Date: Mon, 26 Jun 2017 16:27:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-3075) Bifurcate ServerConnection, create factory and feature toggle MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 26 Jun 2017 16:27:03 -0000 [ https://issues.apache.org/jira/browse/GEODE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063348#comment-16063348 ] ASF subversion and git services commented on GEODE-3075: -------------------------------------------------------- Commit 4ace36af00a22e0995a2e0d07db75f5508524a25 in geode's branch refs/heads/develop from [~gosullivan] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4ace36a ] GEODE-3075: Add an integration test for the ServerConnectionFactory the current implementation is bogus, but does test that the flow works. > Bifurcate ServerConnection, create factory and feature toggle > ------------------------------------------------------------- > > Key: GEODE-3075 > URL: https://issues.apache.org/jira/browse/GEODE-3075 > Project: Geode > Issue Type: Sub-task > Components: client/server > Reporter: Galen O'Sullivan > > Make a factory that creates instances of the new subclasses of {{ServerConnection}} : {{NewClientServerConnection}} and {{LegacyServerConnection}}. This will be the basis for future refactors. This should involve minimal changes to {{AcceptorImpl}} and a minimal implementation of {{NewClientServerConnection}}. All the existing functionality of {{ServerConnection}} must still work. > To do this, we will need a feature toggle so that the new client protocol (which will now be in a broken state) never gets run in production, but can be enabled for testing. This should probably be set via a hidden system property and not through any config that is a part of the public API. -- This message was sent by Atlassian JIRA (v6.4.14#64029)