Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Tue, 13 Jun 2017 14:25:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13078051.1496856250000.9987.1497363900183@Atlassian.JIRA>
In-Reply-To: <JIRA.13078051.1496856250000@Atlassian.JIRA>
References: <JIRA.13078051.1496856250000@Atlassian.JIRA> <JIRA.13078051.1496856250467@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3048) Tests that require the Gradle test
 runner should fail descriptively when run through Intellij
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 13 Jun 2017 14:25:10 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047958#comment-16047958 ] 

ASF GitHub Bot commented on GEODE-3048:
---------------------------------------

Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/575#discussion_r121690753
  
    --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java ---
    @@ -39,6 +39,8 @@
     import org.junit.Before;
     import org.junit.Rule;
     import org.junit.Test;
    +import org.junit.ClassRule;
    --- End diff --
    
    Imports should be reordered to the project standard ordering.


> Tests that require the Gradle test runner should fail descriptively when run through Intellij
> ---------------------------------------------------------------------------------------------
>
>                 Key: GEODE-3048
>                 URL: https://issues.apache.org/jira/browse/GEODE-3048
>             Project: Geode
>          Issue Type: Bug
>          Components: management, tests
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>
> We have some tests the only pass when run through gradle (as opposed to running via the Intellij test runner).  If one of these tests fails in CI, it is easy to being debugging them in the IDE without realizing that they will *never* pass when not run via gradle.  Until we fix the underlying issues that require running through gradle, it would be nice for such tests to detect when they are running outside of gradle, and to notify the user that they should be expected to fail.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)