geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-3075) Bifurcate ServerConnection, create factory and feature toggle
Date Tue, 27 Jun 2017 19:56:00 GMT


ASF subversion and git services commented on GEODE-3075:

Commit e62e825090db50f77faaa3e222595ee1026d7a6c in geode's branch refs/heads/feature/GEODE-2804v3
from [~gosullivan]
[;h=e62e825 ]

GEODE-3075: fix an integration test.

I think the test fails because another test doesn't clean up system
properties when it's done.

> Bifurcate ServerConnection, create factory and feature toggle
> -------------------------------------------------------------
>                 Key: GEODE-3075
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Galen O'Sullivan
>            Assignee: Galen O'Sullivan
>             Fix For: 1.3.0
> Make a factory that creates instances of the new subclasses of {{ServerConnection}} :
{{NewClientServerConnection}} and {{LegacyServerConnection}}. This will be the basis for future
refactors. This should involve minimal changes to {{AcceptorImpl}} and a minimal implementation
of {{NewClientServerConnection}}. All the existing functionality of {{ServerConnection}} must
still work.
> To do this, we will need a feature toggle so that the new client protocol (which will
now be in a broken state) never gets run in production, but can be enabled for testing. This
should probably be set via a hidden system property and not through any config that is a part
of the public API.

This message was sent by Atlassian JIRA

View raw message