geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-3075) Bifurcate ServerConnection, create factory and feature toggle
Date Mon, 26 Jun 2017 16:27:00 GMT


ASF subversion and git services commented on GEODE-3075:

Commit 4ace36af00a22e0995a2e0d07db75f5508524a25 in geode's branch refs/heads/develop from
[;h=4ace36a ]

GEODE-3075: Add an integration test for the ServerConnectionFactory

the current implementation is bogus, but does test that the flow works.

> Bifurcate ServerConnection, create factory and feature toggle
> -------------------------------------------------------------
>                 Key: GEODE-3075
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Galen O'Sullivan
> Make a factory that creates instances of the new subclasses of {{ServerConnection}} :
{{NewClientServerConnection}} and {{LegacyServerConnection}}. This will be the basis for future
refactors. This should involve minimal changes to {{AcceptorImpl}} and a minimal implementation
of {{NewClientServerConnection}}. All the existing functionality of {{ServerConnection}} must
still work.
> To do this, we will need a feature toggle so that the new client protocol (which will
now be in a broken state) never gets run in production, but can be enabled for testing. This
should probably be set via a hidden system property and not through any config that is a part
of the public API.

This message was sent by Atlassian JIRA

View raw message