geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3073) Refactor/rename OrderByComparatorUnmapped
Date Fri, 16 Jun 2017 23:46:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052532#comment-16052532
] 

ASF GitHub Bot commented on GEODE-3073:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/591

    GEODE-3073: Renamed OrderByComparatorUnmapped to OrderByComparatorMapped

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3073)
    
    `OrderByComparatorUnmapped.java` actually uses mapping, which is why it should really
be called `OrderByComparatorMapped.java`. Some refactoring was also done (similar to the refactoring
done in [pull request #580](https://github.com/apache/geode/pull/580), although to a lesser
extent).
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3073-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #591
    
----
commit b915804d857fd3efd7fefe6af45a6a8c44745bed
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-06-16T20:41:21Z

    GEODE-3073: Renamed OrderByComparatorUnmapped to OrderByComparatorMapped and refactored
the code a bit.

----


> Refactor/rename OrderByComparatorUnmapped
> -----------------------------------------
>
>                 Key: GEODE-3073
>                 URL: https://issues.apache.org/jira/browse/GEODE-3073
>             Project: Geode
>          Issue Type: Improvement
>          Components: querying
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> It would make more sense to rename {{OrderByComparatorUnmapped.java}} to {{OrderByComparatorMapped.java}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message